Fixed setting of sorted array of listeners in EventManager to empty a… #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray, when it shouldn't.
|
Great catch! Do you think you can provide a test case, so we won't reintroduce the bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kdyby\Events\EventManager::sorted[$eventName]is set to an empty array even when there are more subscribers for the same event. It's enough to remove one and it effectively removes all of them, because when the event is dispatched, the EventManager looks at this array and doesn't find any listeners, even tough there are still some inKdyby\Events\EventManager::listeners.This pull request should fix this issue. Now, the array is only set to an empty array after explicit check, that
listeners[$eventName]array is also empty.The addressed issue is described more in depth here.